Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reported as bug on Alliedmodders discord by user
magnat2645
, if a plugin clones the entity factory handle with sourcemod'sCloneHandle
native and then deletes the original handle. CallingCEntityFactory.GetFactoryOfEntity
will end up returning the now deleted and therefore invalid factory handle.Rather than allowing the cloning of handles for entity factories, as it's still not clear how we want cross-plugin interaction to work, and because it would require a significant rewrite of the internal code base to allow us. I opt to fully restrict handle cloning for entity factories. Instead the constructor for entity factories has been edited like so
This will allow plugins to allocate entity factories for other plugins.